This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
fix: remove form unit tests #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilindsay
approved these changes
Jan 9, 2024
sanakhandvsa
approved these changes
Jan 9, 2024
fibble
approved these changes
Jan 9, 2024
4 tasks
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* fix: remove form unit tests * fix: add missing permits namespace * chore: bump `olcs-common` to `5.0.0-alpha.3`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove form unit tests
In the unit tests we're using a 1000+ line class (
AbstractFormValidationTestCase.php) asserting that these annotations exist and then asserting the annotation is doing what Laminas is saying it does.This feels like a lot of duplication without any value, we're just writing things twice and testing already tested vendor code at unit test level.